Endpoint /internal/messages#677
Open
hippolyteblot wants to merge 17 commits into
Open
Conversation
axlbonnet
reviewed
May 27, 2026
|
|
||
| @DeleteMapping("/send/{id}") | ||
| public void deleteSentMessage(@PathVariable long id) throws VipException { | ||
| messageBusiness.remove(id); |
Contributor
There was a problem hiding this comment.
add in MessageBusiness the verification the message is sent by the current user (or the current user is an admin)
| } | ||
| } | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
We will make 2 different endpoints:
- POST /messages (with a Message model)
- POST /messages/groups (with a GroupMessage model)
get rid of SendMessageRequest
Simple verification:
- beginner cannot post on /messages
- only a group admin of the group specified on the group message (or a VIP admin) can post on /messages/groups
Maybe validation of NotBlank through @notblank annotation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new PR allows the backend to provide new routes under
/internal/messages.Here are the new endpoints:
/internal/messages: Returns inbox messages for the current user/internal/messages/send: Returns messages sent by the current user/internal/messages/groups: Returns inbox group messages for the current user/internal/messages: Allows the current user to send a new message (can be a group message)/internal/messages/{id}: Deletes a message for the current recipient only/internal/messages/send/{id}: Deletes a message as the sender (removes the message for all recipients)/internal/messages/{id}/read: Marks the message as read by the current user (must be a recipient)Here is also two new endpoints (and associated business methods) that allows to search for a user, or a group (used for recommendations when sending messages)